Grouping ground attack mods together is causing drag to be applied when it shouldn't be, or not at all. They should be separated.

[=MERCS=JenkemJunkie]

When a plane like the P51B chooses the "ground attack modification" it gets the same drag value applied regardless if I choose just bombs, just rockets, or both after they've been dropped/jettisoned, and in-game testing shows I get the same speed after dropping/jettisoning as well. On the P51D the bombs and rockets are chosen separately without being grouped in a "ground attack modification" and this issue doesn't occur, and I reach different speeds in-game after dropping/jettisoning.

 

 

It happens because there's only 1 global drag value applied when "ground attack modification" is chosen, and no drag is applied on the rack itself later in the code. CXaS is the variable used for drag, all people need to know is higher number = more drag.

 

The P51B benefits from this, and other planes like the P47 (it never gets a break in this game) get shafted. It gets a drag penalty for all 3 racks (left wing, right wing and belly) when "ground attack modification" is chosen (even though only wing racks get added on the model), and an additional drag value gets applied again when bombs or rockets are chosen afterwards. When bombs are added to the wing racks on the 47 additional attachments are visible on the model, so I'm assuming this double application of drag is intentional in this instance, but the drag applied on the invisible belly rack when "ground attack modification" is chosen shouldn't be there as the rack isn't there. Still it would be nice not to have the global application at all, and allow us to choose mods individually. If I wanted to take rockets only for instance, I'm stuck taking the drag penalty of all 3 wing racks (2 visible, 1 invisible) as well the drag of the rockets. 

The A6 gets screwed over by this system too as when it chooses the G3/R3 mod then adds a bomb load, it gets the drag applied from the ETC 501 rack applied twice. Once from the G3/R3 mod, and again from the "Bomb load" mod. And it's testable in game as your top speed in game will be different after dropping the bombs as well depending on if you just took G3/R3 or G3/R3 and bombs. 

 

 

 

Other planes are affected by this too. To add the Panzerblitz rockets to the A8 the player must first choose the F8/G8 option which applies the bomb rack drag that won't exist when the rocket racks are there. So the A8 now has the drag from the Panzerblitz racks and from the non-existent bomb racks as well. It would be better to separate the 190 engine upgrades and armor from the wing racks, because the current system causes drag values to be applied twice in certain circumstances. The Typhoon is a good example of how to make these mods, it has the engine upgrades, the armor and the bombs and rockets all as separate mods and there's no issue with drag values being applied multiple times or not at all. 

 

Edit:

I forgot to add mass of the racks can also be affected as well, as in the case of the A6 where it gets the 30kg of the belly rack added twice in addition to the drag being added twice.

 

 

 

Edited January 28, 2023 by =MERCS=JenkemJunkie

[354thFG_Rails]

Make a bug report my man. Good find!

Edited February 1, 2023 by 86th_Rails

[=MERCS=JenkemJunkie]

I guess it should have gone here instead?

I'll repost it later.